feat: implement robustness guards
This commit is contained in:
101
scripts/guards/image-reference-normalization-guard.mjs
Normal file
101
scripts/guards/image-reference-normalization-guard.mjs
Normal file
@@ -0,0 +1,101 @@
|
||||
#!/usr/bin/env node
|
||||
|
||||
import fs from 'fs'
|
||||
import path from 'path'
|
||||
import process from 'process'
|
||||
import { pathToFileURL } from 'url'
|
||||
|
||||
const root = process.cwd()
|
||||
const handlersDir = path.join(root, 'src', 'lib', 'workers', 'handlers')
|
||||
|
||||
export const NORMALIZATION_HELPER_ALLOWLIST = new Set([
|
||||
'src/lib/workers/handlers/image-task-handler-shared.ts',
|
||||
])
|
||||
|
||||
const ACCEPTED_NORMALIZATION_MARKERS = [
|
||||
/\bnormalizeReferenceImagesForGeneration\s*\(/,
|
||||
/\bnormalizeToBase64ForGeneration\s*\(/,
|
||||
/\bgenerateLabeledImageToCos\s*\(/,
|
||||
]
|
||||
|
||||
function fail(title, details = []) {
|
||||
process.stderr.write(`\n[image-reference-normalization-guard] ${title}\n`)
|
||||
for (const detail of details) {
|
||||
process.stderr.write(` - ${detail}\n`)
|
||||
}
|
||||
process.exit(1)
|
||||
}
|
||||
|
||||
function walk(dir, out = []) {
|
||||
if (!fs.existsSync(dir)) return out
|
||||
const entries = fs.readdirSync(dir, { withFileTypes: true })
|
||||
for (const entry of entries) {
|
||||
if (entry.name === '.git' || entry.name === '.next' || entry.name === 'node_modules') continue
|
||||
const fullPath = path.join(dir, entry.name)
|
||||
if (entry.isDirectory()) {
|
||||
walk(fullPath, out)
|
||||
continue
|
||||
}
|
||||
if (entry.name.endsWith('.ts')) out.push(fullPath)
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
function toRel(fullPath) {
|
||||
return path.relative(root, fullPath).split(path.sep).join('/')
|
||||
}
|
||||
|
||||
function usesGenerationReferenceImages(content) {
|
||||
return /\bresolveImageSourceFromGeneration\s*\(/.test(content) && /\breferenceImages\s*:/.test(content)
|
||||
}
|
||||
|
||||
function hasNormalizationMarker(content) {
|
||||
return ACCEPTED_NORMALIZATION_MARKERS.some((pattern) => pattern.test(content))
|
||||
}
|
||||
|
||||
export function inspectImageReferenceNormalization(relPath, content) {
|
||||
if (NORMALIZATION_HELPER_ALLOWLIST.has(relPath)) return []
|
||||
if (!usesGenerationReferenceImages(content)) return []
|
||||
if (hasNormalizationMarker(content)) return []
|
||||
return [
|
||||
`${relPath} uses resolveImageSourceFromGeneration with referenceImages but does not reference normalizeReferenceImagesForGeneration/normalizeToBase64ForGeneration/generateLabeledImageToCos`,
|
||||
]
|
||||
}
|
||||
|
||||
export function findImageReferenceNormalizationViolations(scanRoot = root) {
|
||||
const scanDir = path.join(scanRoot, 'src', 'lib', 'workers', 'handlers')
|
||||
return walk(scanDir)
|
||||
.map((fullPath) => {
|
||||
const relPath = path.relative(scanRoot, fullPath).split(path.sep).join('/')
|
||||
const content = fs.readFileSync(fullPath, 'utf8')
|
||||
return inspectImageReferenceNormalization(relPath, content)
|
||||
})
|
||||
.flat()
|
||||
}
|
||||
|
||||
export function main() {
|
||||
if (!fs.existsSync(handlersDir)) {
|
||||
fail('Missing src/lib/workers/handlers directory')
|
||||
}
|
||||
|
||||
const handlerFiles = walk(handlersDir)
|
||||
const violations = handlerFiles
|
||||
.map((fullPath) => {
|
||||
const relPath = toRel(fullPath)
|
||||
const content = fs.readFileSync(fullPath, 'utf8')
|
||||
return inspectImageReferenceNormalization(relPath, content)
|
||||
})
|
||||
.flat()
|
||||
|
||||
if (violations.length > 0) {
|
||||
fail('Found image reference normalization violations', violations)
|
||||
}
|
||||
|
||||
process.stdout.write(
|
||||
`[image-reference-normalization-guard] OK handlers=${handlerFiles.length} allowlist=${NORMALIZATION_HELPER_ALLOWLIST.size}\n`,
|
||||
)
|
||||
}
|
||||
|
||||
if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
|
||||
main()
|
||||
}
|
||||
Reference in New Issue
Block a user